Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password Reset Endpoint #198

Merged
merged 17 commits into from
Oct 24, 2023
Merged

Password Reset Endpoint #198

merged 17 commits into from
Oct 24, 2023

Conversation

TheTedder
Copy link
Contributor

Closes #158

@TheTedder TheTedder requested a review from a team as a code owner October 17, 2023 18:12
Dalet
Dalet requested changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@Dalet Dalet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An assertion in a test should be added, otherwise it looks good.

LeaderboardBackend/Models/Requests/UserRequests.cs Outdated Show resolved Hide resolved
LeaderboardBackend.Test/Features/Users/ResetPasswordTests.cs Show resolved Hide resolved
@TheTedder TheTedder requested a review from Dalet October 22, 2023 21:54
@TheTedder TheTedder merged commit a8063b3 into leaderboardsgg:main Oct 24, 2023
1 check passed
@TheTedder TheTedder deleted the pwd-reset branch October 24, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dalet Dalet Dalet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task: Reset password endpoint
2 participants
@TheTedder @Dalet