Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: ensure database initialization before OneTimeSetup of IntegrationTestsBase children runs #175

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

Dalet
Copy link
Contributor

@Dalet Dalet commented Aug 11, 2023

Fixes an issue where the testcontainers database is sometimes not yet initialized in OneTimeSetup methods of IntegrationTestsBase children. (noticed this issue with #169)

Also upgraded the testcontainers package since a new version has bugfixes for Docker detection. (@zysim had trouble with this)

@Dalet Dalet requested a review from a team as a code owner August 11, 2023 16:33
Copy link
Contributor

@TheTedder TheTedder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love small PRs.

@Dalet Dalet merged commit 2902565 into leaderboardsgg:main Aug 11, 2023
1 check passed
@Dalet Dalet deleted the fix-testdb-init branch August 16, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants