Return 404 for malformed confirmation ID.

leaderboardsgg · Sep 22, 2023 · 8c760d9 · 8c760d9
1 parent 5798640
commit 8c760d9
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/LeaderboardBackend.Test/Features/Users/AccountConfirmationTests.cs b/LeaderboardBackend.Test/Features/Users/AccountConfirmationTests.cs
@@ -187,6 +187,21 @@ public async Task ConfirmAccount_BadConfirmationId()
         user!.Role.Should().Be(UserRole.Registered);
     }
 
+    [Test]
+    public async Task ConfirmAccount_MalformedConfirmationId()
+    {
+        HttpClient client = _factory.WithWebHostBuilder(builder =>
+        {
+            builder.ConfigureTestServices(services =>
+            {
+                services.AddSingleton<IClock, FakeClock>(_ => new(Instant.FromUnixTimeSeconds(1)));
+            });
+        }).CreateClient();
+
+        HttpResponseMessage res = await client.PutAsync("/account/confirm/not_a_guid", null);
+        res.StatusCode.Should().Be(HttpStatusCode.NotFound);
+    }
+
     [Test]
     public async Task ConfirmAccount_BadRole()
     {

diff --git a/LeaderboardBackend/Controllers/AccountController.cs b/LeaderboardBackend/Controllers/AccountController.cs
@@ -202,7 +202,6 @@ [FromBody] RecoverAccountRequest request
     /// <param name="id">The confirmation token.</param>
     /// <param name="confirmationService">IAccountConfirmationService dependency.</param>
     /// <response code="200">The account was confirmed successfully.</response>
-    /// <response code="400">The token was malformed.</response>
     /// <response code="404">The token provided was invalid or expired.</response>
     /// <response code="409">The user's account was either already confirmed or banned.</response>
     [AllowAnonymous]

diff --git a/LeaderboardBackend/openapi.json b/LeaderboardBackend/openapi.json
@@ -229,7 +229,7 @@
             "description": "The account was confirmed successfully."
           },
           "400": {
-            "description": "The token was malformed.",
+            "description": "Bad Request",
             "content": {
               "application/json": {
                 "schema": {