WIP

.github/workflows/pr-check-trailing-whitespace.yml

@@ -0,0 +1,21 @@
+name: Ensure there are no trailing whitespace
+on: [pull_request]
+
+jobs:
+  check_trailing_whitespace:
+    runs-on: ubuntu-latest
+    name: Check trailing whitespace
+    steps:
+      - uses: actions/checkout@v4
+      - name: Get changed files
+        id: changed-files
+        uses: tj-actions/changed-files@v39
+      - name: Check trailing whitespace in changed files
+        run: |-
+          exit_code=0
+          for file in ${{ steps.changed-files.outputs.all_changed_files }}; do
+            if grep -n '[[:blank:]]$' ${file}; then
+              exit_code=1
+            fi
+          done
+          exit $exit_code

clang/utils/ci/buildkite-pipeline.yml

@@ -17,17 +17,6 @@ env:
     # LLVM RELEASE bump version
     LLVM_HEAD_VERSION: "17"
 steps:
-  - label: "Format"
-    commands:
-      - "clang/utils/ci/run-buildbot check-format"
-    agents:
-      queue: "linux"
-    retry:
-      automatic:
-        - exit_status: -1  # Agent was lost
-          limit: 2
-    timeout_in_minutes: 120
-
   - label: "Building and testing clang (Linux)"
     commands:
       - "clang/utils/ci/run-buildbot build-clang"

clang/utils/ci/run-buildbot

@@ -69,9 +69,6 @@ cmake --version
 ninja --version
 
 case "${BUILDER}" in
-check-format)
-    ! grep -rnI '[[:blank:]]$' clang/lib clang/include clang/docs
-;;
 build-clang)
     mkdir install
     # We use Release here to avoid including debug information. Otherwise, the

libcxx/utils/ci/run-buildbot

@@ -261,9 +261,6 @@ check-generated-output)
            --exclude 'transcoding.pass.cpp' \
            --exclude 'underflow.pass.cpp' \
            || false
-
-    # Reject code with trailing whitespace
-    ! grep -rn '[[:blank:]]$' libcxx/include libcxx/src libcxx/test libcxx/benchmarks || false
 ;;
 #
 # Various Standard modes