Tighten checks for IR aggregate sizes

ldc-developers · Aug 18, 2024 · 6551a7d · 6551a7d
1 parent 6bd5d9a
commit 6551a7d
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 1 deletion.
diff --git a/ir/iraggr.cpp b/ir/iraggr.cpp
@@ -11,6 +11,7 @@
 
 #include "dmd/aggregate.h"
 #include "dmd/declaration.h"
+#include "dmd/errors.h"
 #include "dmd/expression.h"
 #include "dmd/identifier.h"
 #include "dmd/init.h"
@@ -217,8 +218,12 @@ IrAggr::createInitializerConstant(const VarInitMap &explicitInitializers) {
 
   // tail padding?
   const size_t structsize = aggrdecl->size(Loc());
-  if (offset < structsize)
+  if (offset < structsize) {
     add_zeros(constants, offset, structsize);
+  } else if (offset > structsize) {
+    error(Loc(), "ICE: IR aggregate constant size exceeds the frontend size");
+    fatal();
+  }
 
   // get LL field types
   llvm::SmallVector<llvm::Type *, 16> types;

diff --git a/ir/irtypeclass.cpp b/ir/irtypeclass.cpp
@@ -12,6 +12,7 @@
 #include "dmd/aggregate.h"
 #include "dmd/declaration.h"
 #include "dmd/dsymbol.h"
+#include "dmd/errors.h"
 #include "dmd/mtype.h"
 #include "dmd/target.h"
 #include "dmd/template.h"
@@ -98,6 +99,11 @@ IrTypeClass *IrTypeClass::get(ClassDeclaration *cd) {
   isaStruct(t->type)->setBody(builder.defaultTypes(), builder.isPacked());
   t->varGEPIndices = builder.varGEPIndices();
 
+  if (instanceSize && getTypeAllocSize(t->type) != instanceSize) {
+    error(cd->loc, "ICE: class IR size does not match the frontend size");
+    fatal();
+  }
+
   IF_LOG Logger::cout() << "class type: " << *t->type << std::endl;
 
   return t;

diff --git a/ir/irtypestruct.cpp b/ir/irtypestruct.cpp
@@ -11,6 +11,7 @@
 
 #include "dmd/aggregate.h"
 #include "dmd/declaration.h"
+#include "dmd/errors.h"
 #include "dmd/init.h"
 #include "dmd/mtype.h"
 #include "dmd/template.h"
@@ -91,6 +92,11 @@ IrTypeStruct *IrTypeStruct::get(StructDeclaration *sd) {
     builder.addTailPadding(sd->structsize);
     isaStruct(t->type)->setBody(builder.defaultTypes(), builder.isPacked());
     t->varGEPIndices = builder.varGEPIndices();
+
+    if (getTypeAllocSize(t->type) != sd->structsize) {
+      error(sd->loc, "ICE: struct IR size does not match the frontend size");
+      fatal();
+    }
   }
 
   IF_LOG Logger::cout() << "final struct type: " << *t->type << std::endl;

diff --git a/tests/compilable/gh4734.d b/tests/compilable/gh4734.d
@@ -0,0 +1,20 @@
+// RUN: %ldc -c %s
+
+align(1) struct Item {
+    KV v;
+    uint i;
+}
+
+struct KV {
+    align(1) S* s;
+    uint k;
+}
+
+struct S {
+    Table table;
+}
+
+struct Table {
+    char a;
+    Item v;
+}