Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PRT - Consumer optimizer QoS client #1705

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

shleikes
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Sep 19, 2024

Test Results

2 207 tests  ±0   2 207 ✅ ±0   24m 31s ⏱️ - 1m 9s
  145 suites ±0       0 💤 ±0 
    7 files   ±0       0 ❌ ±0 

Results for commit 2115cb1. ± Comparison against base commit 130d0f1.

♻️ This comment has been updated with latest results.

protocol/metrics/consumer_optimizer_qos_client.go Outdated Show resolved Hide resolved
protocol/metrics/consumer_optimizer_qos_client.go Outdated Show resolved Hide resolved
protocol/metrics/consumer_optimizer_qos_client.go Outdated Show resolved Hide resolved
protocol/metrics/consumer_optimizer_qos_client.go Outdated Show resolved Hide resolved
protocol/rpcconsumer/relay_processor.go Show resolved Hide resolved
protocol/rpcconsumer/rpcconsumer.go Outdated Show resolved Hide resolved
protocol/rpcconsumer/rpcconsumer.go Outdated Show resolved Hide resolved
@@ -128,6 +147,10 @@ func (pu *PairingUpdater) updateInner(latestBlock int64) {
continue
}
}

for _, updatable := range pu.pairingStakeEntriesUpdatables {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of adding a new updater type, we can just update the stake from inside the consumer session manager for a specific chain. also makes more sense to have it there after filtering.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 437c614

@@ -93,6 +93,19 @@ func (cst *ConsumerStateTracker) RegisterForPairingUpdates(ctx context.Context,
}
}

func (cst *ConsumerStateTracker) RegisterForPairingStakeEntriesUpdates(ctx context.Context, pairingUpdatable updaters.PairingStakeEntriesUpdatable, specId string) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for that after the pairing updater comment.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in 437c614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants