fix: LaunchDevly: Search clear not clearing filter (#424)

* Fix search clear not clearing filter * Remove logs
launchdarkly · Sep 13, 2024 · dd9df47 · dd9df47
1 parent 216dc95
commit dd9df47
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/internal/dev_server/ui/src/EnvironmentSelector.tsx b/internal/dev_server/ui/src/EnvironmentSelector.tsx
@@ -77,8 +77,9 @@ export function EnvironmentSelector({
           <Input
             id="environmentSearch"
             value={searchQuery}
-            onChange={(e) => setSearchQuery(e.target.value)}
+            onChange={(e) => setSearchQuery(e.target.value || '')}
             placeholder="Search environments..."
+            aria-label="Search environments"
           />
         </div>
         <span

diff --git a/internal/dev_server/ui/src/Flags.tsx b/internal/dev_server/ui/src/Flags.tsx
@@ -222,7 +222,7 @@ function Flags({
       </Box>
       <Stack gap="4">
         <Inline gap="4">
-          <SearchField>
+          <SearchField aria-label="Search flags">
             <Group>
               <Icon name="search" size="small" />
               <Input
@@ -231,12 +231,14 @@ function Flags({
                   setSearchTerm(e.target.value);
                   setCurrentPage(0); // Reset pagination
                 }}
+                aria-label="Search flags input"
               />
               <IconButton
                 aria-label="clear"
                 icon="cancel-circle-outline"
                 size="small"
                 variant="minimal"
+                onPress={() => setSearchTerm('')}
               />
             </Group>
           </SearchField>