Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: issue forms with reason-listings #3476

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

CommanderStorm
Copy link
Contributor

Does your PR solve an issue?

As discussed in #3471, I have added a field to the form.
I have also migrated to using issue-forms as they are a bit better too fill out and users are less likely to flat-out ignore the form.

You can preview it here:

@CommanderStorm CommanderStorm changed the title Better issue forms choreBetter issue forms Aug 31, 2024
@CommanderStorm CommanderStorm changed the title choreBetter issue forms chore: issue forms with reason-listings Aug 31, 2024
Copy link
Collaborator

@abonander abonander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits.

.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
Comment on lines 31 to 36
value: |
* SQLx version: [REQUIRED]
* SQLx features enabled: [REQUIRED]
* Database server and version: [REQUIRED] (MySQL / Postgres / SQLite <x.y.z>)
* Operating system: [REQUIRED]
* `rustc --version`: [REQUIRED]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well break these out into separate fields.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough.
This has the downside of looking a bit longer in the issue that is genereated, but that is likely an ok downside

.github/ISSUE_TEMPLATE/feature_request.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yml Outdated Show resolved Hide resolved
attributes:
label: Additional Context
description: Add any other context or screenshots about the feature request here
placeholder: ...
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What maybe would be nice is a field where they list some relevant areas (e.g. mysql, postgres, macros, etc).

Also, "is this a breaking change? why or why not?"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsure about the wording on this one. We maybe need to iterate on the wording a bit.

What kind of answers would you like to this question?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And should this field be mandatory?

@CommanderStorm
Copy link
Contributor Author

CommanderStorm commented Sep 4, 2024

Being upfront:
It might take me a few days to address that changes (even though they are extremely minor), depending when I have the time to break out my laptop between sightseeing (GitHub mobile does not have an apply suggestion button, am currently on vacation ^^)

Sorry, hope that does not bother you too much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants