\__fontspec_check_script:Nn fails in some cases #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If for some reason \curr@fontshape is not the really
the shape of the currently selected font, e.g. due
to a missing shape, and LuaTeX is the used engine,
the expansion of '\curr@fontshape/\f@size' is not
the name of the font switch that needs to be checked.
Example:
\documentclass{article}
\usepackage{fontspec}
\setmainfont{David CLM}
\begin{document}
\scshape % comment this line to see the effect
\ExplSyntaxOn
\fontspec_if_script:nTF{hebr}{yes}{no}
\end{document}
Note how this example returns true with LuaTeX but
false with XeTeX.
It would be more reliable to use \the\font to get
the name of the switch of the currently selected font.
Udi-Fogiel
referenced
this pull request
in reutenauer/polyglossia
Sep 6, 2024
This could happen if a shape is not found and substituted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
If for some reason \curr@fontshape is not the really the shape of the currently selected font,
e.g. due to a missing shape, and LuaTeX is the used engine,
the expansion of '\curr@fontshape/\f@size' is not
the name of the font switch that needs to be checked. Example:
It would be more reliable to use \the\font to get
the name of the switch of the currently selected font.
Todos
Minimal example demonstrating the new/fixed functionality
Note how this example returns true with LuaTeX but false with XeTeX.