Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it compatible with Jira 8 and other SAML apps #6

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

max-allan-surevine
Copy link

@max-allan-surevine max-allan-surevine commented May 29, 2019

This should allow you to use the plugins with Jira 8.
It also makes it work if your jira is not in the context path /.
(Although does have issues when it is / . Needs a better Java person than me to figure out!)
And sets username/email/etc sensibly rather than assuming username is email everywhere and not setting real names.

@xdgc
Copy link

xdgc commented May 29, 2019

Thank you! I was just starting to write the ComponentManager fix as well.

Unfortunately I'm not sure anyone at LastPass still cares about this since @bcopeland left. :(

@max-allan-surevine
Copy link
Author

I've raised a ticket with LastPass, suggested they get one of their own devs to look at my "alternative context" quick fix. Iirc, it will add "null" to the URL if you host jira in / , and of course /null gets a 404 response.
If they don't merge it, I'll ask them to remove Jira from the list of supported SAML apps. There is actually a Microsoft SAML plugin for Jira that might be worth considering if LastPass give up on it. I haven't had a chance to trial it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants