Feature/sfc.gen.init #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
factored out common code between sfc.gen.component/init implemented injection TODO: come up with a demo component and templatize refs #2
added insert_in_blocks_matching_fragment function which (obstinately) uses regex to add code fragments to elixir blocks (or to a quote do...end block inside an elixir block Should have done it with leex or the actual elixir parser
test fixes after extracting common code started writing tests for sfc.gen.init: the phx.gen.live tests don't generate a full app, just touch some files. I want to make sure my injections stay robust to changes in phoenix, so I run Mix.Tasks.Phx.New(~w(live_app --live)) first to get all the pieces. There was no easy way to just extract the pieces I need individually, plus that would be just another way for the tests to get stale
tests for all the insertions
injects in `.formatter.exs`, `dev/config.exs`, and the view macro in `lib/my_app_web.ex`. optionally creates a demo card component in either single-file or with depending on option
|
refs #2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.