Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip migrations when Telescope is disabled #1508

Closed
wants to merge 1 commit into from

Conversation

kauhat
Copy link

@kauhat kauhat commented Aug 22, 2024

Hi,

My project uses an in-memory SQLite database for testing in CI, and RefreshDatabase tests stopped working after upgrading to v5 and publishing the Telescope migration file. In my case, the tests were failing as the telescope.storage.database.connection config value had not been updated to point to the SQLite database.

This change skips Telescope migrations when the TELESCOPE_ENABLED flag is false, such as when running tests using the standard Laravel PHPUnit config. However, it's not a great solution as migrations will sometimes need to be re-run after enabling Telescope.

Related:
#1476

@driesvints
Copy link
Member

These migrations are published to your app. You can modify them how you like 👍

@driesvints driesvints closed this Aug 22, 2024
@kauhat
Copy link
Author

kauhat commented Aug 22, 2024

That's fair enough. Thanks for your quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants