Skip migrations when Telescope is disabled #1508
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
My project uses an in-memory SQLite database for testing in CI, and
RefreshDatabase
tests stopped working after upgrading to v5 and publishing the Telescope migration file. In my case, the tests were failing as thetelescope.storage.database.connection
config value had not been updated to point to the SQLite database.This change skips Telescope migrations when the
TELESCOPE_ENABLED
flag is false, such as when running tests using the standard Laravel PHPUnit config. However, it's not a great solution as migrations will sometimes need to be re-run after enabling Telescope.Related:
#1476