[4.x] Add primary keys to database tables #1407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested in #1380, this PR adds Primary keys to the `telescope_entries_tags` and the `telescope_monitoring` tables, to allow HA MySQL deployments.
|
@driesvints how should we deal with existing installations? New migration? Describe it in the release notes? |
driesvints
approved these changes
Nov 14, 2023
|
@zoispag it's not needed for existing apps to adjust as no code was changed. Existing installs will just continue to function as-is. |
driesvints
changed the title
|
Since this may break applications, you can just customize the migrations to create the index you want. We document this here:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #1380, this PR adds Primary keys to the
telescope_entries_tagsand thetelescope_monitoringtables, to allow HA MySQL deployments.