Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve search by tag #1383

Closed
wants to merge 4 commits into from
Closed

improve search by tag #1383

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06bc9ac
improve search by tag to get data with approximate tag not write exac…
She3bo Sep 21, 2023
f8c0bdc
fix style
She3bo Sep 21, 2023
25bb74d
fix style
She3bo Sep 21, 2023
408882d
improve query
She3bo Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Storage/EntryModel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,11 @@ protected function whereTag($query, EntryQueryOptions $options)
return $query->whereIn('uuid', function ($query) use ($tags) {
$query->select('entry_uuid')->from('telescope_entries_tags')
->whereIn('entry_uuid', function ($query) use ($tags) {
$query->select('entry_uuid')->from('telescope_entries_tags')->whereIn('tag', $tags->all());
$query->select('entry_uuid')->from('telescope_entries_tags')->where(function ($q) use ($tags) {
foreach ($tags as $tag) {
$q->where('tag', 'like', '%'.$tag.'%');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you probably mean orWhere() here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your comment. I updated it, please check it again

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me now :)

}
});
});
});
});
Expand Down