Don't use constructor injection in console commands, and inject into …

…handle() instead. (#1327)
laravel · Mar 17, 2023 · 88ca4cb · 88ca4cb
1 parent ec8a10a
commit 88ca4cb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 46 deletions.
diff --git a/src/Console/PauseCommand.php b/src/Console/PauseCommand.php
@@ -21,35 +21,16 @@ class PauseCommand extends Command
      */
     protected $description = 'Pause all Telescope watchers';
 
-    /**
-     * The cache repository implementation.
-     *
-     * @var \Illuminate\Contracts\Cache\Repository
-     */
-    protected $cache;
-
-    /**
-     * Create a new command instance.
-     *
-     * @param  \Illuminate\Contracts\Cache\Repository  $cache
-     * @return void
-     */
-    public function __construct(CacheRepository $cache)
-    {
-        parent::__construct();
-
-        $this->cache = $cache;
-    }
-
     /**
      * Execute the console command.
      *
+     * @param  \Illuminate\Contracts\Cache\Repository  $cache
      * @return void
      */
-    public function handle()
+    public function handle(CacheRepository $cache)
     {
-        if (! $this->cache->get('telescope:pause-recording')) {
-            $this->cache->put('telescope:pause-recording', true, now()->addDays(30));
+        if (! $cache->get('telescope:pause-recording')) {
+            $cache->put('telescope:pause-recording', true, now()->addDays(30));
         }
 
         $this->info('Telescope watchers paused successfully.');

diff --git a/src/Console/ResumeCommand.php b/src/Console/ResumeCommand.php
@@ -21,35 +21,16 @@ class ResumeCommand extends Command
      */
     protected $description = 'Unpause all Telescope watchers';
 
-    /**
-     * The cache repository implementation.
-     *
-     * @var \Illuminate\Contracts\Cache\Repository
-     */
-    protected $cache;
-
-    /**
-     * Create a new command instance.
-     *
-     * @param  \Illuminate\Contracts\Cache\Repository  $cache
-     * @return void
-     */
-    public function __construct(CacheRepository $cache)
-    {
-        parent::__construct();
-
-        $this->cache = $cache;
-    }
-
     /**
      * Execute the console command.
      *
+     * @param  \Illuminate\Contracts\Cache\Repository  $cache
      * @return void
      */
-    public function handle()
+    public function handle(CacheRepository $cache)
     {
-        if ($this->cache->get('telescope:pause-recording')) {
-            $this->cache->forget('telescope:pause-recording');
+        if ($cache->get('telescope:pause-recording')) {
+            $cache->forget('telescope:pause-recording');
         }
 
         $this->info('Telescope watchers resumed successfully.');