Use selenium/standalone-chromium on AMD and ARM #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
Jubeki
changed the title
|
@Jubeki this one has conflicts. |
Jubeki
force-pushed
the
use-selenium
branch
from
6fa43d3
to
c44cd81
Compare
Jubeki
force-pushed
the
use-selenium
branch
from
c44cd81
to
826d26b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unifies the use to
selenium/standalone-chromiumon both AMD and ARM, instead of before the two different images:selenium/standalone-chromefor AMDselenium/standalone-chromiumfor ARMWhat currently happens: If you are on AMD-based platform the first image will be used, if you are on an ARM-based platform the second-image will be used.
If a team has different platforms, this can result in a conflict. Therefor I would recommend using the standalone-chromium image, which supports both platforms.