Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment option to horizon:status command to allow for liveness check on individual environment #1331

Conversation

PrinsFrank
Copy link
Contributor

@PrinsFrank PrinsFrank commented Oct 5, 2023

When working with multiple environments12 the 'horizon:status' command only tells you if a master supervisor is running, but not if a master supervisor is running for a specific environment.

So when running the command

php artisan horizon

We can check if that command was successful and is running by executing:

php artisan horizon:status

Things become murky when we run the following commands:

php artisan horizon --environment=foo
php artisan horizon --environment=bar

When we now run the php artisan horizon:status command we know that horizon is running, but not if horizon is running for both environments. After this PR gets merged, the following now all become valid commands:

php artisan horizon:status // Works as usual and is BC
php artisan horizon:status --environment=foo
php artisan horizon:status --environment=bar

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants