[12.x] force Eloquent\Collection::partition
to return a base Collection
#53304
+14
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the way
partition
currently works is it returns anEloquent\Collection
ofEloquent\Collection
s, which is technically not allowed by the generic type hints defined by the class, and also doesn't really make any logical sense for how someone would want to use this.It also causes issues in the IDE because based on the type hints it assumes ALL values of an
Eloquent\Collection
are of typeEloquent\Model
, which is not the case for thepartition
method.what we really want is a
Support\Collection
ofEloquent\Collection
s. we can accomplish this by first calling theparent::partition
method to get our (illegal) result ofEloquent\Collection<int, Eloquent\Collection>
, and then converting it to a base collection to end up with the desiredSupport\Collection<int, Eloquent\Collection>
.someone please double check my generic return type docblock. I'm relatively new to them, but I think this should be correct and fix the issues.
#53298 #53283