[9.x] Set previous exception on HttpResponseException
#51960
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
hafezdivandari
force-pushed
the
11.x-http-response-exception-previous
branch
from
a31df6d
to
dc2e925
Compare
hafezdivandari
changed the title
HttpResponseExceptionHttpResponseException
|
The latest commit on 9.x branch has failing test: https://github.com/laravel/framework/tree/9.x |
|
Thanks @hafezdivandari. We don't maintain v9 any longer sorry. If this change needs to be made we'll need to do it in v10 and then differentiate between Laravel versions in Passport v12. Or only make the change in Passport v13. |
|
@driesvints sure, I've resent this on #51968 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this for laravel/passport#1763 - Passport's current version still supports Laravel 9.x so we have to make this change on framework 9.x
The exception handler supports handling http response exceptions by extending
\Illuminate\Http\Exceptions\HttpResponseExceptionbut there is no way to set the actual / previous exception when extending this class?