Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Add AsCommand attribute to Console commands stub by default #51936

Closed
wants to merge 1 commit into from

Conversation

wilsenhc
Copy link
Contributor

@wilsenhc wilsenhc commented Jun 27, 2024

Just thinking that maybe this should be the default behavior after all the work done in #50617 so I updated the stub.

@wilsenhc
Copy link
Contributor Author

wilsenhc commented Jun 27, 2024

Or maybe it would be better to setup a new Laravel contract/attribute that inherits from Symfony's AsCommand and maybe clean up some stuff from the Commands structure as to not have duplicate values everywhere? And target this change for 12.x instead

Like moving the signature, description and aliases to be by default in the AsCommand attribute (with fallback to the class attributes for backwards compatibility)

Let me know what you think!

@taylorotwell
Copy link
Member

I think it's generally fine to not have this. We mainly did it in the framework because we have so many commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants