Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Update Command::fail() dockblock and tests #51914

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

seriquynh
Copy link
Contributor

Command::fail() method throws ManuallyFailedException or Throwable, so I added @throws dockblock for it.

I also add some missing assertions/tests:

  • Create exception from null: The fixed string "Command failed manually." is used as message of the thrown exception.
  • Create exception from string: This given string is used as message of the thrown exception.
  • If Command::fail() receives a Throwable instance, it will throw it right the way without transformation/modification.

Please see tests more more details!

@taylorotwell taylorotwell merged commit 1076c91 into laravel:11.x Jun 26, 2024
30 checks passed
@seriquynh seriquynh deleted the update-command-fail branch June 27, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants