[11.x] Support third-party relations in model:show command

[staudenmeir]

The model:show command finds a model's relations by analyzing the code of its methods and looking for $this->hasMany( etc. This doesn't detect third-party relations (like eloquent-has-many-deep). We could build a whole system for packages to hook into, but that would be overkill, IMO.

Instead, we can check the method's return type and see if it's a subclass of the base Relation class. Not everybody uses return types, but I hope that most do nowadays.

I also added a check to skip methods with parameters. That's necessary to ignore some internal methods of third-party packages. Since relations shouldn't have parameters, I don't consider this a breaking change.

The command doesn't have any tests.

[calebdw]

I also added a check to skip methods with parameters. That's necessary to ignore some internal methods of third-party packages.

I'm just curious, if you rejected all methods that weren't public would it solve this issue without having to specifically filter by the lack of parameters?

[staudenmeir]

I'm just curious, if you rejected all methods that weren't public would it solve this issue without having to specifically filter by the lack of parameters?

@calebdw I would have preferred this approach, but the eloquent-has-many-deep package contains public methods that need to be ignored (but need to stay public).

[staudenmeir]

Also: The command invokes all the methods it found and this fails if a method requires parameters.

framework/src/Illuminate/Database/Console/ShowModelCommand.php

Line 213 in 8fde0ea

$relation = $method->invoke($model);