[10.x] Current page items always show on the first page

[hiidemo]

When paging from the sample data array with Paginator class, $items variable always has data from the first page, without changing according to the current page number.

[driesvints]

Tests fail here.

[hiidemo]

Tests fail here.

The code below always returns ["one", "two", "three"] regardless of changing $currentPage

use Illuminate\Pagination\Paginator;
use Illuminate\Http\Request;

class PaginationSample extends Controller
{
    public function index(Request $request)
    {
        $data = ['one', 'two', 'three', 'four', 'five', 'six', 'seven', 'eight', 'nine', 'ten'];

        $currentPage = Paginator::resolveCurrentPage();
        $col = collect($data);
        $perPage = 3;
        $items = new Paginator($col, $perPage, $currentPage);
        $items->setPath($request->url());
        $items->appends($request->all());
        dd($items->items());
        
        // add in view
        // {!! $items->links() !!}
        
        return view('index', compact('items'));
    }
}

[driesvints]

I don't feel this change makes sense sorry.

[dennisprudlo]

@hiidemo i think there is a misunderstanding of how the paginator works. The items you pass as a first parameter into the constructor should be the already paginated items. The $perPage and $currentPage parameters don't tell the class "how to paginate the items" but rather "what state the items represent"

[hiidemo]

@hiidemo i think there is a misunderstanding of how the paginator works. The items you pass as a first parameter into the constructor should be the already paginated items. The $perPage and $currentPage parameters don't tell the class "how to paginate the items" but rather "what state the items represent"

I tried passing the first parameter as paginated items (code example below). The resulting data displays the current page correctly but does not show the button to move to the next page in all cases.

use Illuminate\Pagination\Paginator;
use Illuminate\Http\Request;

class PaginationSample extends Controller
{
    public function index(Request $request)
    {
        $data = ['one', 'two', 'three', 'four', 'five', 'six', 'seven', 'eight', 'nine', 'ten'];

        $currentPage = Paginator::resolveCurrentPage();
        $col = collect($data);
        $perPage = 3;
        $currentPageItems = $col->slice(($currentPage - 1) * $perPage, $perPage)->all();
        $items = new Paginator($currentPageItems, $perPage, $currentPage);
        $items->setPath($request->url());
        $items->appends($request->all());
        dd($items->items());
        
        // add in view
        // {!! $items->links() !!}
        
        return view('index', compact('items'));
    }
}

[dennisprudlo]

This kind of paginator doesn't know how many items the whole dataset has, so it doesn't know whether there is more data (more pages) or not.

You have to either pass more data than the $perPage parameter specifies (for example 11 items when you have 10 items per page) or simply use a paginator that knows how many items the whole dataset has, like the LengthAwarePaginator