Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't suggest cache tags for Redis #9286

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Don't suggest cache tags for Redis #9286

merged 2 commits into from
Feb 1, 2024

Conversation

dbhynds
Copy link
Contributor

@dbhynds dbhynds commented Jan 29, 2024

The upgrade guide indicates that Redis cache tags got a performance improvement. However based on discussions linked below, it appears that usage of redis cache tags is not recommended. The outdated guidance in the upgrade guide caused a series of significant bugs in our production application. This PR updates the docs to recommend against using cache tags until a suitable solution can be found.

The current upgrade guide still contains a broken link to the documentation on cache tagging (which was removed as a result of Taylor's comment in the second link there).

If there is another recommended way for implementing Redis cache tags, I'd be happy to write up docs for that, but I'm not seeing one in my quick perusal of the issues, PRs, and conversations in github.

@taylorotwell
Copy link
Member

taylorotwell commented Jan 31, 2024

@dbhynds Are you able to test the changes in laravel/framework#48078 to see if it fixes your issues?

@dbhynds
Copy link
Contributor Author

dbhynds commented Feb 1, 2024

I'll need some time to look into that question. We didn't see the problem in any of our pre-production environments or manual testing. The associated bug in our app was only discovered in prod. So I'm going to need some time to figure out how to duplicate it locally. That said, I'll try to carve out some time in the next week or two to try out that PR and see if it works.

@taylorotwell taylorotwell merged commit 1b40cbd into laravel:10.x Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants