Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable translations by default #14

Closed
wants to merge 1 commit into from
Closed

Enable translations by default #14

wants to merge 1 commit into from

Conversation

pktharindu
Copy link
Contributor

No description provided.

@Wulfheart Wulfheart mentioned this pull request May 8, 2020
Open
@Wulfheart
Copy link
Contributor

grafik
#12.

@danharrin danharrin added the enhancement New feature or request label May 9, 2020
dakira
dakira approved these changes May 18, 2020
View reviewed changes
Copy link

@dakira dakira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge this, it just adds i18n in the exact same way as the Tailwind preset and the default Laravel preset already do.

@dakira dakira mentioned this pull request May 18, 2020
Closed
@imliam
Copy link
Contributor

imliam commented May 18, 2020

Please merge this, it just adds i18n in the exact same way as the Tailwind preset and the default Laravel preset already do.

There's been a discussion in #12 about translation support out-of-the-box that I want to get a working copy of before merging this. The Tailwind and default presets may use this translation method, but it's not the best way to translate for a multitude of reasons.

@danharrin
Copy link
Member

I think an approach similar to #15 is much better, since it allows for contextual translation instead of using the English as default. Thank you for the PR though.

@danharrin danharrin closed this Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakira dakira dakira approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pktharindu @Wulfheart @imliam @danharrin @dakira