Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added skippable columns #3

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Added skippable columns #3

merged 2 commits into from
Jul 17, 2023

Conversation

giagara
Copy link
Contributor

@giagara giagara commented Jul 17, 2023

Added skippable columns in config file: useful for created_at, updated_at, deleted_at

@giagara giagara marked this pull request as ready for review July 17, 2023 09:29
@Sairahcaz Sairahcaz merged commit dda40e3 into laracraft-tech:main Jul 17, 2023
1 check passed
@Sairahcaz
Copy link
Member

Great idea, thanks! We could also think about the add created_at, updated_at, deleted_at as default skip columns...
I think you never need rules for them right?

@giagara
Copy link
Contributor Author

giagara commented Jul 17, 2023

Well, yeah i think this should be defaulted.
Since you've merged it, i think I'll open a new PR asap to change the behavior.

@Sairahcaz
Copy link
Member

Well, yeah i think this should be defaulted. Since you've merged it, i think I'll open a new PR asap to change the behavior.

Yes this would be great!

Also the tests seem not to run fine, please also take a look on these:
https://github.com/laracraft-tech/laravel-schema-rules/actions/runs/5575309317

giagara added a commit to giagara/laravel-schema-rules that referenced this pull request Jul 17, 2023
Sairahcaz added a commit that referenced this pull request Jul 19, 2023
Fix error in PR #3 and refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants