[nl] prevent 2+ part compound words from being accepted #9971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaumeortola
reviewed
Dec 21, 2023
|
|
||
| CompoundAcceptor() { | ||
| tagger = Languages.getLanguageForShortCode("nl").getTagger(); | ||
| this.DutchTagger = new DutchTagger(); |
There was a problem hiding this comment.
We prefer to avoid creating new instances. Use the previous version. I will add a default tagger for NL.
jaumeortola
reviewed
Dec 21, 2023
jaumeortola
reviewed
Dec 21, 2023
| @@ -558,14 +558,14 @@ public class CompoundAcceptor { | |||
| } | |||
| } | |||
|
|
|||
| private final Tagger tagger; | |||
| private final DutchTagger DutchTagger; | |||
There was a problem hiding this comment.
The class is capitalized (DuchTagger), but the variable should be lowercase (dutchTagger).
jaumeortola
reviewed
Dec 21, 2023
| } | ||
|
|
||
| public CompoundAcceptor(Tagger tagger) { | ||
| this.tagger = tagger; | ||
| public CompoundAcceptor(DutchTagger dutchTagger) { |
There was a problem hiding this comment.
This constructor (lines 566-568) seems unnecessary. It is never used, and the tagger is initialized in line 561.
jaumeortola
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.