[de] try to ignore words added as exception #9956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luisa-LT
requested review from
danielnaber and
jaumeortola
and removed request for
danielnaber
|
More tests can be added to |
jaumeortola
approved these changes
Dec 19, 2023
danielnaber
reviewed
Dec 20, 2023
| ignore = true; | ||
| break; | ||
| } | ||
| String pattern = "(?i)\\b" + Pattern.quote(exception) + "\\b"; |
There was a problem hiding this comment.
This line/variable doesn't seem to be used
There was a problem hiding this comment.
Should I undo the changes again?
There was a problem hiding this comment.
Not needed, but you could delete this line, as it's not needed. IntelliJ should also show pattern in light gray, indicating the variable is never used.
There was a problem hiding this comment.
Thanks!
commit: 200fe55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://regression.languagetoolplus.com/via-http/2023-12-15/de-DE/result_java_OLD_SPELLING.html
Note: please do not merge (to merge after premium deploy)