[pt] Add logic for Brazilian municipality/state mapping #9946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-goulart
force-pushed
the
pt/grammar/city_list
branch
from
30108e4
to
ecd8a8b
Compare
danielnaber
reviewed
Dec 18, 2023
| if (suggestion.equals(underlined)) { | ||
| return null; | ||
| } | ||
| BrazilianToponymMap map = new BrazilianToponymMap(); |
There was a problem hiding this comment.
Would it make sense to make this a static constant? We maybe don't want to re-initialize the object every time there's a potential match.
There was a problem hiding this comment.
Yes, we should definitely do that. I was certain I had, but I think I moved it around a bit and forgot to put it back.
susanaboatto
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core of the rule is now a regexp, and we just call the rule filter to make sure we're dealing with an actual city.
This rule doesn't check if the city actually belongs in that state – that'll be a different rule. The idea here is that only things that could be conceivably thought of as Brazilian cities should trigger the state abbreviation separation rule.
We still need to improve (or apply a similar logic?) to the US states rule.