[de] improve germanSpeller #9821
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgnesKleinhans
requested review from
p-goulart,
Luisa-LT,
affemitkaraffe and
St-ac-y
p-goulart
reviewed
Dec 4, 2023
There was a problem hiding this comment.
Trying to understand the logic here was quite taxing, but let me see if I understand:
- if the German tokeniser refuses to split
wordinto multiple parts, try again with a non-strict tokeniser (that was already there); - iterate over all non-Fugen-S words;
- if
wordstarts with one of them, then... - set
part2to whatever's left once you remove it; - clean leading hyphens;
- and make sure the word lengths match (where does the
3come from?) - perform your regular misspelling checks.
Right?
Comment on lines
+2220
to
+2230
| String part2 = " "; | ||
| for (String w : wordsWithoutInfixS) { // wordsWithHyphen | ||
| if (word.startsWith(w)) { | ||
| part2 = word.substring(w.length()); | ||
| if (part2.startsWith("-")) { | ||
| part2 = part2.substring(1); | ||
| } else if (word.length() > w.length() && w.length() > 3) { | ||
| part2 = uppercaseFirstChar(part2.substring(0)); | ||
| } | ||
| return (!isMisspelled(part2) || ignorePotentiallyMisspelledWord(part2)) && isNoun(part2); | ||
| } |
There was a problem hiding this comment.
This stretch looks over-indented 🙃
...etool-language-modules/de/src/test/java/org/languagetool/rules/de/GermanSpellerRuleTest.java
Show resolved
Hide resolved
languagetool-language-modules/de/src/main/java/org/languagetool/rules/de/GermanSpellerRule.java
Outdated
Show resolved
Hide resolved
Luisa-LT
reviewed
Dec 6, 2023
...getool-language-modules/de/src/main/resources/org/languagetool/resource/de/words_infix_s.txt
Outdated
Show resolved
Hide resolved
Luisa-LT
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@p-goulart Could you please review my PR? Thank you :-)
@Luisa-LT @St-ac-y