Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[be] Update Belarusian spell dictionary #9692

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

alex73
Copy link
Contributor

@alex73 alex73 commented Nov 16, 2023

Dictionary contains updated set of Belarusian words

@danielnaber
Copy link
Member

What do you think of publishing the binary dict as a separate Maven artifact that LT uses as an external dependency? This way, we'd avoid putting more binary data into the LT main repo.

@alex73
Copy link
Contributor Author

alex73 commented Nov 17, 2023

Well, I can do it, of course. Could you please to point me the same exist external dependency ? I'm not sure that I have enough knowledge of languagetool internals to do it myself.

@alex73
Copy link
Contributor Author

alex73 commented Dec 11, 2023

@danielnaber So, is it some other language dict that was moved to external dependency ? I would like to use it as example.

@danielnaber
Copy link
Member

@alex73 org.languagetool:portuguese-pos-dict (source) has recently been moved to its own package

@alex73
Copy link
Contributor Author

alex73 commented Dec 12, 2023

@danielnaber Belarusian dictionary created from https://github.com/Belarus/GrammarDB. Can I don't create https://github.com/languagetool-org/belarusian-pos-dict, but add code for build dictionary to https://github.com/Belarus/GrammarDB and publish artifact with hunspell dictionary to Maven Central ?

@danielnaber
Copy link
Member

@alex73 Yes, it doesn't matter where the repo is hosted on github, as long as it's published on Maven Central.

@alex73 alex73 force-pushed the master branch 2 times, most recently from 9cf6372 to 7f607ac Compare December 15, 2023 18:27
@alex73
Copy link
Contributor Author

alex73 commented Dec 15, 2023

@danielnaber I added dictionary as dependency, and looks like languagetool-language-modules/be works good. But "LanguageTool stand-alone GUI" test was failed.

@danielnaber
Copy link
Member

@alex73 I'm sorry, I won't have time to debug that. I suggest you run the affected test in an IDE with a debugger to see what's wrong.

@alex73 alex73 force-pushed the master branch 10 times, most recently from 1ded571 to f07f0e3 Compare December 17, 2023 13:27
@alex73
Copy link
Contributor Author

alex73 commented Dec 17, 2023

@danielnaber I fixed it. Looks like it can be merged to master.
The issue was: when I removed spelling.txt, then "LanguageTool stand-alone GUI" was failed with strange error: https://app.circleci.com/pipelines/github/languagetool-org/languagetool/28091/workflows/367758ac-2a51-4031-aeae-6a8a2258c552/jobs/28247

@danielnaber
Copy link
Member

Have you also moved ignore.txt to the external dependency? It should stay in LT, so it can be changed without updating the external dependency.

@alex73
Copy link
Contributor Author

alex73 commented Dec 18, 2023

@danielnaber Yes, I was moved it into external project. Just returned to LT.

@jaumeortola
Copy link
Member

This looks good to me.
For other languages, the version number is in the main pom.xml file.
Should we do the same for Belarusian?

@alex73
Copy link
Contributor Author

alex73 commented Dec 18, 2023

@jaumeortola I moved version number to the /pom.xml

@jaumeortola jaumeortola self-requested a review December 19, 2023 07:29
@jaumeortola jaumeortola merged commit 0f7b135 into languagetool-org:master Dec 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants