-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[be] Update Belarusian spell dictionary #9692
Conversation
What do you think of publishing the binary dict as a separate Maven artifact that LT uses as an external dependency? This way, we'd avoid putting more binary data into the LT main repo. |
Well, I can do it, of course. Could you please to point me the same exist external dependency ? I'm not sure that I have enough knowledge of languagetool internals to do it myself. |
@danielnaber So, is it some other language dict that was moved to external dependency ? I would like to use it as example. |
@danielnaber Belarusian dictionary created from https://github.com/Belarus/GrammarDB. Can I don't create https://github.com/languagetool-org/belarusian-pos-dict, but add code for build dictionary to https://github.com/Belarus/GrammarDB and publish artifact with hunspell dictionary to Maven Central ? |
@alex73 Yes, it doesn't matter where the repo is hosted on github, as long as it's published on Maven Central. |
9cf6372
to
7f607ac
Compare
@danielnaber I added dictionary as dependency, and looks like languagetool-language-modules/be works good. But "LanguageTool stand-alone GUI" test was failed. |
@alex73 I'm sorry, I won't have time to debug that. I suggest you run the affected test in an IDE with a debugger to see what's wrong. |
1ded571
to
f07f0e3
Compare
@danielnaber I fixed it. Looks like it can be merged to master. |
Have you also moved |
@danielnaber Yes, I was moved it into external project. Just returned to LT. |
This looks good to me. |
@jaumeortola I moved version number to the /pom.xml |
Dictionary contains updated set of Belarusian words