[pt] Add CONCORDANCIA_SOBRESCRITO rule #9202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
August 28, 2023 12:10
- these were some of the lowest-performing Wikipedia rules; - these are all picky and goal_specific; - remove the original wikipedia.txt lines.
- these are already covered by other, more detailed rules - reorder subrules of CRASE_CONFUSION for 'à ele' (was suggesting 'ao ele', since it's masculine).
- also fix some guillemets in the grammar file
p-goulart
force-pushed
the
pt/grammar/clean_up_wikipedia
branch
from
546977d
to
c57a5d3
Compare
p-goulart
force-pushed
the
pt/grammar/agreement_superscript
branch
from
d9357e4
to
72fe88f
Compare
|
This is already covered by our gender agreement rule, isn't it? 
|
|
Looks like it is, but the results are not quite consistent. I suppose I'll just fix the logic in place instead of adding another rule, though. |
|
Case in point – they do behave differently, there's something iffy here. 
|
|
As discussed here, we'll keep this rule separate so as not to Also changes to disambiguation. |
|
@susanaboatto have you had a moment to review this? Afraid this PR might get stale. |
susanaboatto
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple rule that replaces older wikipedia rule. Has better coverage.