Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nl] improve rule HAHA_KOMMA #9193

Merged
merged 1 commit into from
Aug 28, 2023
Merged

[nl] improve rule HAHA_KOMMA #9193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions languagetool-language-modules/nl/src/main/resources/org/languagetool/rules/nl/grammar.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17075,10 +17075,16 @@ regexp case-insensitive maken: (?i)
</rulegroup>
<rulegroup id="HAHA_KOMMA" name="Haha zonder komma">
<rule>
<antipattern>
<token postag="UNKNOWN"/>
<token negate="yes">,</token>
<token regexp="yes" case_sensitive="yes">[Hh]ah[ha]+|[Hh]ih[hi]+|[Hh]eh[he]+</token>
<example>Saito Mokichi's Shinitamau Haha.</example>
</antipattern>
<pattern>
<marker>
<token negate="yes">,</token>
<token regexp="yes">(ha|hi|ho){2,10}</token>
<token negate="yes" regexp="yes">[.,]</token>
<token regexp="yes" case_sensitive="yes">hah[ha]+|hih[hi]+|heh[he]+</token>
</marker>
<token postag="SENT_END"/>
</pattern>
Expand All @@ -17088,15 +17094,15 @@ regexp case-insensitive maken: (?i)
</rule>
<rule>
<antipattern>
<token regexp="yes">(ha|hi|ho){2,10}</token>
<token regexp="yes">hah[ha]+|hih[hi]+|heh[he]+</token>
<token postag="SENT_END"/>
</antipattern>
<pattern>
<token postag_regexp="yes" postag="SENT_START|START"/>
<marker>
<token regexp="yes">(ha|hi|ho){2,10}</token>
<token regexp="yes">hah[ha]+|hih[hi]+|heh[he]+</token>
</marker>
<token negate="yes">,</token>
<token negate="yes">,<exception postag_regexp="yes" postag="ITP.*|UNKNOWN"/></token>
</pattern>
<message>Hier hoort een komma.</message>
<suggestion>\2,</suggestion>
Expand Down
2 changes: 1 addition & 1 deletion languagetool-language-modules/nl/src/main/resources/org/languagetool/rules/nl/style.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,7 @@ USA
<example correction="je">Ik zie <marker>jou</marker> daar wel staan.</example>
</rule>
</rulegroup>
<rulegroup id="WIJ_ZIJ_MIJ_TEMP" name="Wij, zij, jij/jou/jouw, mij → we, ze, je, me" tags="picky" tone_tags="clarity" default="temp_off">
<rulegroup id="WIJ_ZIJ_MIJ_TEMP" name="Wij, zij, mij → we, ze, me" tags="picky" tone_tags="clarity" default="temp_off">
<!-- move to WIJ_ZIJ_MIJ if diff looks good -->
<antipattern>
<token postag="SENT_START"/>
Expand Down