Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pt] suggestion improvements in HIPHEN_SPACE_RULES #9176

Merged
merged 1 commit into from
Aug 25, 2023
Merged

[pt] suggestion improvements in HIPHEN_SPACE_RULES #9176

merged 1 commit into from
Aug 25, 2023

Conversation

susanaboatto
Copy link
Collaborator

@susanaboatto susanaboatto commented Aug 25, 2023 •
edited
Loading

For instances in which the shorter dash was used and the user prefers to keep it that way.

p-goulart
p-goulart approved these changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@p-goulart p-goulart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say I fully see 👁️ what the issue is, but this seems small enough :p

@susanaboatto
Copy link
Collaborator Author

There is the em dash (—) and the en dash (–). I noticed that when the en dash was used, this rule did not keep it as a suggestion, and it should be one.

@susanaboatto susanaboatto merged commit 6a7fb6d into master Aug 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-goulart p-goulart p-goulart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@susanaboatto @p-goulart