[pt-PT] Replaced rule ID:VERBO_PRONOMINAL_DE_V2 with ID:VERBO_PRONOMINAL_DE_V3

[marcoagpinto]

Replaced the old rule with a new, better one, fixing tons of false positives.

Summary by CodeRabbit

• New Features
  • Introduced a new rule for pronominal verbs, enhancing clarity in naming and categorization.
  • The new rule improves formality and conciseness by addressing the optional use of the preposition "de."
  • Includes examples to illustrate correct usage.
• Bug Fixes
  • Removed outdated rules and antipatterns related to pronominal verbs, streamlining the rule set.

[coderabbitai]

Walkthrough

The pull request introduces a new rule, VERBO_PRONOMINAL_DE_V3, which replaces the previous rule group VERBO_PRONOMINAL_DE_V2. This new rule focuses on the usage of specific pronominal verbs related to naming or categorization, particularly addressing the optional use of the preposition "de." It includes patterns for matching relevant verbs and specifies exceptions for certain noun phrases and adjectives. The changes streamline the handling of pronominal verbs in this context and remove outdated antipatterns.

Changes

File Path	Change Summary
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml	Added new rule VERBO_PRONOMINAL_DE_V3, replacing VERBO_PRONOMINAL_DE_V2, and removed previous antipatterns.

Possibly related PRs

• [pt] Fixed FPs in rule ID:OS_DOIS_AS_DUAS_AMBOS_AMBAS #10869: Modifies style.xml to address rule exceptions related to Portuguese language rules, similar to the main PR.
• [pt] Removed "temp_off" from rule ID:OS_DOIS_AS_DUAS_AMBOS_AMBAS #10870: Adjusts the OS_DOIS_AS_DUAS_AMBOS_AMAS rule group in style.xml, focusing on rule adjustments in the same context.
• [pt] Removed "temp_off" from rule ID:OS_DOIS_AS_DUAS_AMBOS_AMBAS #10887: Removes the temp_off designation from the same rule group in style.xml, indicating a connection to rule management.
• [pt-PT] Added subrule to rule ID:INFORMALITIES #10888: Adds a new subrule to the INFORMALITIES rule group in style.xml, continuing the theme of enhancing language rules.
• [pt-PT] Removed "temp_off" from subrule in ID:INFORMALITIES #10889: Removes the temp_off designation from a subrule in style.xml, indicating ongoing adjustments to rules in the same context.

Suggested reviewers

• p-goulart
• susanaboatto

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 6b814ca and 64b6609.

📒 Files selected for processing (1)

• languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml (1)

5147-5170: New rule VERBO_PRONOMINAL_DE_V3 implemented to replace VERBO_PRONOMINAL_DE_V2

The new rule VERBO_PRONOMINAL_DE_V3 has been implemented to replace the previous VERBO_PRONOMINAL_DE_V2. This change aligns with the PR objectives of addressing false positives. The rule focuses on verbs indicating naming, designation, or categorization, where the use of the preposition "de" is optional.

Positive aspects:

1. The rule is marked as 'temp_off' by default, allowing for testing before full deployment.
2. It includes a comprehensive list of verbs related to naming and categorization.
3. The message provides a clear explanation of the optional nature of "de" and its impact on formality and conciseness.
4. The pattern includes exceptions to avoid false positives with certain nouns and adjectives.

Suggestions for improvement:

1. Consider adding more examples to cover various use cases, including negative examples where the rule shouldn't apply.
2. The exception lists are quite long. It might be beneficial to move these to separate entity definitions for better maintainability.

Consider refactoring the exception lists into separate entity definitions for improved maintainability:

<!ENTITY exceptions_group1 "ac?ção|acesso|acontecimento|ajuda|alerta|análise|ansiedade|assistência|atenção|atitude|áudio|ausência|aviso|base|capacidade|cara|causa|cautela|chamada|chance|circunstância|comando|competência|condição|conhecimento|consciência|consequência|consideração|conta|contagem|crédito|cuidado|custo|desejo|deslocação|destaque|dica|dinheiro|direc?ção|direito|dúvida|efeito|emprego|entrada|escolha|esforço|estado|estima|estudo|eventualidade|exame|experiência|facto|falta|fato|fac?tura|finalidade|forma|frente|fronteira|função|fundamento|habilidade|homenagem|honra|imagem|importância|incerteza|indicação|indício|intenção|jeito|justificação|lembrança|liderança|limite|localização|maneira|medida|meio|melhoria|memória|menção|mérito|modo|momento|motivo|movimento|necessidade|notificação|objec?tivo|observação|opção|opinião|oportunidade|ordem|papel|parecer|parte|porção|posição|possibilidade|posto|precaução|preço|prémio|preocupação|prevenção|princípio|privilégio|progresso|propósito|prova|razão|recompensa|recordação|referência|regresso|relevância|respeito|resposta|resultado|retorno|retribuição|sabedoria|significância|situação|solução|telefone|tempo|tentativa|teste|trabalho|troco|urgência|uso|utilização|valor|vídeo|volta|vontade">

<!ENTITY exceptions_group2 "ac?tuação|aflição|alarme|amparo|ânsia|aparência|aptidão|assento|ac?tividade|auxílio|avaliação|barreira|capital|carência|cargo|celeridade|celular|certeza|citação|clima|cobrança|controle|controlo|decisão|deferência|defesa|desenvolvimento|deslocamento|destreza|determinação|distinção|encargo|ensaio|evidência|exemplo|face|firmeza|frac?ção|fronte|fundação|ganho|gasto|gesto|incidência|influência|ingresso|início|intercâmbio|intuito|ligação|local|manejo|meta|moral|movimentação|ocupação|orgulho|orientação|pagamento|pago|passagem|percepção|peso|pressa|presságio|presunção|procedimento|protec?ção|prudência|realce|regressão|reversão|rosto|segurança|significado|som|sugestão|talento|técnica|tributo|trocado|vantagem|vigilância|vulto|zelo">

Then use these entities in the rule:

<exception regexp='yes' inflected='yes'>&exceptions_group1;</exception>
<exception regexp='yes' inflected='yes'>&exceptions_group2;</exception>

This approach would make the rule more readable and easier to maintain.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 3a0657a and 6b814ca.

📒 Files selected for processing (1)

• languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml (1 hunks)