Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nl] add compound parts #10881

Merged
merged 1 commit into from
Sep 13, 2024
Merged

[nl] add compound parts #10881

merged 1 commit into from
Sep 13, 2024

Conversation

mark-baas
Copy link
Collaborator

@mark-baas mark-baas commented Sep 13, 2024

Summary by CodeRabbit

  • New Features

    • Added new compound words to the Dutch language resource, including "faillissements," enhancing text processing capabilities.
    • Expanded vocabulary with additional terms such as "aanjaag," "bakfiets," "campus," "crypto," "hidjab," "nep," "spoed," "tram," and "vaccinatie."
  • Bug Fixes

    • Removed the term "wieler" from the vocabulary list to improve accuracy.
  • Tests

    • Introduced new test cases for better coverage of compound word acceptance in Dutch.

Copy link
Contributor

coderabbitai bot commented Sep 13, 2024

Walkthrough

The pull request introduces several updates to the Dutch language resources in LanguageTool. It adds new entries to the needs_s.txt and no_s.txt files, expanding the vocabulary of accepted compound words and terms. Additionally, new test cases are included in the CompoundAcceptorTest class to enhance testing coverage for the acceptCompound method, ensuring it correctly identifies a broader range of Dutch compounds.

Changes

Files Change Summary
languagetool-language-modules/nl/src/main/resources/.../needs_s.txt Added the term faillissements to the list of accepted compound words.
languagetool-language-modules/nl/src/main/resources/.../no_s.txt Added several terms including aanjaag, bakfiets, campus, crypto, hidjab, nep, spoed, tram, vaccinatie, and removed wieler.
languagetool-language-modules/nl/src/test/java/.../CompoundAcceptorTest.java Added new test cases for various compound words to the testAcceptCompound method, enhancing test coverage.

Possibly related PRs

  • [nl] add words to added.txt #10879: This PR adds new entries to the added.txt file for the Dutch language module, which is directly related to enhancing Dutch language resources by adding new terms.

Tip

OpenAI O1 model for chat
  • We have deployed OpenAI's latest O1 model for chat.
  • OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
  • Please share any feedback with us in the discussions post.

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 645be98 and 0795da6.

Files selected for processing (3)
  • languagetool-language-modules/nl/src/main/resources/org/languagetool/resource/nl/compound_acceptor/needs_s.txt (1 hunks)
  • languagetool-language-modules/nl/src/main/resources/org/languagetool/resource/nl/compound_acceptor/no_s.txt (10 hunks)
  • languagetool-language-modules/nl/src/test/java/org/languagetool/rules/nl/CompoundAcceptorTest.java (1 hunks)
Files skipped from review due to trivial changes (2)
  • languagetool-language-modules/nl/src/main/resources/org/languagetool/resource/nl/compound_acceptor/needs_s.txt
  • languagetool-language-modules/nl/src/main/resources/org/languagetool/resource/nl/compound_acceptor/no_s.txt
Additional comments not posted (11)
languagetool-language-modules/nl/src/test/java/org/languagetool/rules/nl/CompoundAcceptorTest.java (11)

55-55: LGTM!

The test case correctly asserts that the compound word "cryptodebacle" should be accepted.


56-56: LGTM!

The test case correctly asserts that the compound word "bakfietsbedrijf" should be accepted.


57-57: LGTM!

The test case correctly asserts that the compound word "campustheater" should be accepted.


58-58: LGTM!

The test case correctly asserts that the compound word "tramschutter" should be accepted.


59-59: LGTM!

The test case correctly asserts that the compound word "zeespiegelonderzoeker" should be accepted.


60-60: LGTM!

The test case correctly asserts that the compound word "nepsupporters" should be accepted.


61-61: LGTM!

The test case correctly asserts that the compound word "hidjabverplichting" should be accepted.


62-62: LGTM!

The test case correctly asserts that the compound word "faillissementspoging" should be accepted.


63-63: LGTM!

The test case correctly asserts that the compound word "spoedaanwijzingen" should be accepted.


64-64: LGTM!

The test case correctly asserts that the compound word "vaccinatieorganisaties" should be accepted.


65-65: LGTM!

The test case correctly asserts that the compound word "aanjaagpartij" should be accepted.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mark-baas mark-baas merged commit 540eaef into languagetool-org:master Sep 13, 2024
2 checks passed
@mark-baas mark-baas deleted the mb-04 branch September 13, 2024 08:13
@coderabbitai coderabbitai bot mentioned this pull request Sep 13, 2024
@coderabbitai coderabbitai bot mentioned this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant