Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pt] Fixed FPs in rule ID:OS_DOIS_AS_DUAS_AMBOS_AMBAS #10860

Merged
merged 2 commits into from
Sep 6, 2024
Merged

[pt] Fixed FPs in rule ID:OS_DOIS_AS_DUAS_AMBOS_AMBAS #10860

merged 2 commits into from
Sep 6, 2024

Conversation

marcoagpinto
Copy link
Member

Heya, @susanaboatto and @p-goulart ,

This should hopefully remove all false positives.

Thanks!

@marcoagpinto
Copy link
Member Author

I have removed more FPs.

Notice that some FPs can't be removed because they require changes in the disambiguator for not detecting certain words as verbs.

But I am not brave enough to “play” with the disambiguator.

Screenshot 2024-09-03 at 05-22-38 Análise de Texto - LanguageTool

@marcoagpinto
Copy link
Member Author

Heya, @susanaboatto and @p-goulart

Any news regarding this pull request?

Thanks!

@marcoagpinto marcoagpinto merged commit 8e101f1 into master Sep 6, 2024
5 checks passed
@marcoagpinto marcoagpinto deleted the lt_marcoagpinto_20240903_0459 branch September 6, 2024 06:50
@marcoagpinto
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susanaboatto susanaboatto susanaboatto approved these changes

@p-goulart p-goulart Awaiting requested review from p-goulart

Assignees
No one assigned
Labels
Portuguese
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcoagpinto @susanaboatto