Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt] Removed "temp_off" from rule ID:ESTAR_AQUI_PARA_INF_VIR_INF #10829

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

marcoagpinto
Copy link
Member

@susanaboatto
Copy link
Collaborator

susanaboatto commented Aug 15, 2024

Note that in pt-BR, vimos ajudar sounds unnatural and would likely not be accepted, the past form viemos ajudar being preferred. In fact, the conjugation of this verb in the third-person plural is avidly avoided in the present tense, often being replaced with the singular a gente or other alternatives (likely due to confusion with the verb ver). I think this entire rule would sound better in pt-BR if the verb "vir" was converted into its past perfect form when the original verb "estar" is in the simple present:

Eu estou aqui para ajudar → Vim ajudar.

Is this also the case for pt-PT? If not, I would suggest moving this rule to the pt-PT grammar.

Also, this example:

Nós sempre estamos aqui para ajudar.

does not seem to work well for any given pronoun — you might want to consider adding exceptions for sentences with adverbs like sempre, as they imply a change of meaning when this rule is applied.

@marcoagpinto
Copy link
Member Author

Sure… I will do it tonight or at 5am and tomorrow when both you and Pedro arrive at work I will have the rule fixed, and I will readd the temp_off.

Thanks for the feedback.

@marcoagpinto
Copy link
Member Author

@susanaboatto

I have just fixed the rule.

I changed the rule like you suggested, changing the verbal form it shows as output.

Here is the resulting file:

2.txt

@marcoagpinto marcoagpinto merged commit 717a311 into master Aug 19, 2024
5 checks passed
@marcoagpinto marcoagpinto deleted the lt_marcoagpinto_20240815_0642 branch August 19, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants