Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt] Added numbers to ENTITY numero_por_extenso #10718

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

marcoagpinto
Copy link
Member

Heya, @susanaboatto and @p-goulart ,

“milhar” and “milhares” were missing.

@p-goulart
Copy link
Collaborator

This entity is not actually used anywhere but pt-PT files... where it is redefined. You may want to remove its redeclaration in pt-PT/grammar.xml and pt-PT/style.xml and import the entity from the proper file.

@marcoagpinto
Copy link
Member Author

@p-goulart

Does that mean I can merge it?

Pedro, thank you for telling me that it is only used in pt-PT as I didn't know.

The entities to be used on pt-PT: on Saturday or Sunday, I will “import” them to pt-PT.

I am scared to do it so soon because I need you and Susana “looking over my shoulder” on this improvement.

It is too major an improvement, and I am too scared to fail.

It is better for me to dedicate a reasonable number of time to doing it.

@p-goulart
Copy link
Collaborator

You should be free to merge it, since it should only affect pt-PT and no tests fail, but it won't have any effect until you actually import it in the relevant files. So I don't see why you would.

@marcoagpinto marcoagpinto merged commit 4cb34f0 into master Jul 11, 2024
2 checks passed
@marcoagpinto marcoagpinto deleted the lt_marcoagpinto_20240711_0723 branch July 11, 2024 09:18
@marcoagpinto
Copy link
Member Author

I will import it to the relevant files on Saturday or Sunday.

I need to dedicate a reasonable time to it to make sure it will be well done, and you and Susana to look over my shoulder on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants