[pt] Add English contraction rule #10669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaumeortola
approved these changes
Jun 20, 2024
p-goulart
force-pushed
the
pt/grammar/improve_english_entities
branch
from
ae7eaf2
to
8b4be06
Compare
p-goulart
force-pushed
the
pt/grammar/english_contractions
branch
from
21d2d47
to
b657665
Compare
susanaboatto
approved these changes
Jun 25, 2024
p-goulart
force-pushed
the
pt/grammar/improve_english_entities
branch
from
fb4b5c9
to
5f4f53d
Compare
p-goulart
force-pushed
the
pt/grammar/english_contractions
branch
from
b657665
to
148a618
Compare
- the English ignore logic balks at stuff like "whats", which the English tagger fails to tag, and therefore doesn't get recognised as English; - in order to *kind of* address it, or at least help users and maybe convince them to stop adding "whats" to their personal dictionaries, we're adding this rule here, with relevant suggestions; - global English spellchecking still requires a lot of thinking, but this rule here should be safe.
p-goulart
force-pushed
the
pt/grammar/english_contractions
branch
from
17620f7
to
724e5d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the English ignore logic balks at stuff like "whats", which the English tagger fails to tag, and therefore doesn't get recognised as English;
in order to kind of address it, or at least help users and maybe convince them to stop adding "whats" to their personal dictionaries, we're adding this rule here, with relevant suggestions;
global English spellchecking still requires a lot of thinking, but this rule here should be safe.