[pt] Improve English phrase detection #10666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
p-goulart
commented
Jun 18, 2024
p-goulart
commented
- optimise English word entities;
- add entity for prefixed words (e.g. "overzealous");
- expand logic to handle single English words separated by commas (e.g. "Good, Bad");
- expand logic to handle English words followed by possessive (e.g. "children's") -- note that this does not handle the possessive marker "'", since this could be too easily confused with a regular apostrophe and I'd rather avoid being too aggressive now;
- add more tests.
p-goulart
force-pushed
the
pt/grammar/improve_english_entities
branch
4 times, most recently
from
ae7eaf2
to
8b4be06
Compare
susanaboatto
approved these changes
Jun 25, 2024
- optimise English word entities; - add entity for prefixed words (e.g. "overzealous"); - expand logic to handle single English words separated by commas (e.g. "Good, Bad"); - expand logic to handle English words followed by possessive (e.g. "children's") -- note that this does not handle the possessive marker "'", since this could be too easily confused with a regular apostrophe and I'd rather avoid being too aggressive now; - add more tests.
p-goulart
force-pushed
the
pt/grammar/improve_english_entities
branch
from
fb4b5c9
to
5f4f53d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.