[pt] Fix hexadecimal number bug #10601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- by doing `if (matcher.find())` we were only ever checking the first match within a single text sample; - changing it from an `if` block to a `while` loop means that, so long as there are instances to find, we will continue comparing them with those in the actual rule match object; - this bug affected any usage of RegexAntiPatternFilter where the rule regexp pattern matched multiple times in the same sentence.
- the tailing letters (usually measurement unit abbreviations) must be present in the regexp if we want the regexp antipattern to function properly; - add a couple of examples testing hex numbers; - add a couple of speller rule tests to drive the point home.
jaumeortola
approved these changes
May 20, 2024
jaumeortola
reviewed
May 20, 2024
| @@ -3466,6 +3466,20 @@ | |||
| <disambig action="ignore_spelling"/> | |||
| </rule> | |||
|
|
|||
| <rule id="HEXADECIMAL_NOTATION"> | |||
There was a problem hiding this comment.
The 'name' attribute is missing. I think it is required in some tests.
There was a problem hiding this comment.
This is a rule within a rulegroup, though, and the rulegroup has both a name and an id attribute. Should be fine..?
There was a problem hiding this comment.
Probably yes. If the tests pass, it is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few FPs with valid hexadecimals like
0x5Astemming from the multiplication rule1.To achieve that, we:
RegexAntiPatternFilter(@jaumeortola);RegexAntiPatternFiltertoMULTIPLICATION_SIGN;MULTIPLICATION_SIGN;HEXADECIMAL_NOTATIONandOCTAL_NOTATIONrules to the disambiguator so we can reliably ignore spelling for valid hexadecimal and octal numerals2;1: this is not a new issue, but the matches appear as new because of the recent improvements to the disambiguator.
2: I decided to only ignore spelling of C-style hexadecimal and C-inspired octal numerals (i.e.
0x...and0o..., respectively). Most other notations seemed like they'd conflict with legitimate spelling issues, and I didn't want to be too aggressive.