-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pt] Dictionary update to v1.0.1 #10559
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-goulart
changed the title
[pt] Dictionary update to v1.0.0
[pt] Dictionary update to v1.0.1
May 2, 2024
- remove '_ORTHOGRAPHY' suffix to allow users more control; - add 'picky' and formal/academic tags; - this should only really work as of v0.16 of the dictionary, where 'email' is accepted in pt-BR.
- as of dict v1.0.1
- rule A_PREPOSITION, sub-rule 4 was removing the preposition tag from 'a' even when the determiner reading had already been discarded, leading to a NULL-tagged 'a'; - this had to be done here for... reasons... there was *one* new rule that was breaking because of this...
susanaboatto
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this version...
v1.0.0
email
is finally accepted alongsidee-mail
, with hyphenation enforced as apicky
rule (closes "email" with no hyphen is also correct portuguese-pos-dict#27)v1.0.1
(bugfix)English spelling 🇬🇧 🇺🇸
We use the following heuristics:
If the English tagger dictionary lookup fails, the word is not valid in English, and we do not tag it as
_english_ignore_
. This means that, later, we run the Portuguese speller on such words.The original version of my idea went even further. I wanted to tag all such words and, later, actually get suggestions for them from the English speller.
Currently, if a user misspells a word in English, they will be probably irrelevant suggestions in Portuguese, rather than the more relevant ones in English. This could be a future improvement.
Lol ignore the branch name. Originally this was going to be
v0.16
, but @maphjo pointed out it was probably time to revisit the versioning scheme. This wouldn't normally be a major release, as it introduces no breaking changes, but conceptually it makes sense to start withv1.0.0
finally, and we're not planning any breaking changes to the dictionary binaries in the near future.