Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[de] compound improvements #10311

Merged
merged 35 commits into from
Jul 10, 2024
Merged

[de] compound improvements #10311

merged 35 commits into from
Jul 10, 2024

Conversation

affemitkaraffe
Copy link
Collaborator

@affemitkaraffe affemitkaraffe commented Feb 13, 2024 •
edited
Loading

  • refactoring
  • make sure that compound parts are either nouns, verb stems or other prefixes are spelled correctly
  • make SUB:NOM:SIN and no infix s the default for compounds parts
  • allow gender neutral forms in compounds (e. g. SEO-Expert*innen)
  • do not allow old spelling in German compounds (e. g. Abflußleitung)
  • allow for more special prefixes in German compounds (e. g. Thermal-, Anti-, Ur-)
  • distinguish between nouns that require singular/plural (e. g. Gasehersteller, Hundzwinger)

-problems:

  • compounds that pass the checks but are nonsensical (e. g. Eisbergspritze) will lead to new FNs
  • but AI rules are expected to detect between 66% - 75% of those FNs

affemitkaraffe and others added 17 commits February 9, 2024 15:45
danielnaber
danielnaber requested changes Jun 21, 2024
View reviewed changes
...anguage-modules/de/src/main/java/org/languagetool/tokenizers/de/GermanCompoundTokenizer.java Outdated Show resolved Hide resolved
...anguage-modules/de/src/main/java/org/languagetool/tokenizers/de/GermanCompoundTokenizer.java Outdated Show resolved Hide resolved
...anguage-modules/de/src/main/java/org/languagetool/tokenizers/de/GermanCompoundTokenizer.java Outdated Show resolved Hide resolved
...anguage-modules/de/src/main/java/org/languagetool/tokenizers/de/GermanCompoundTokenizer.java Outdated Show resolved Hide resolved
languagetool-language-modules/de/src/main/resources/org/languagetool/resource/de/verb_stems.txt Outdated Show resolved Hide resolved
...getool-language-modules/de/src/main/resources/org/languagetool/resource/de/verb_prefixes.txt Show resolved Hide resolved
...etool-language-modules/de/src/main/resources/org/languagetool/resource/de/other_prefixes.txt Outdated Show resolved Hide resolved
@affemitkaraffe affemitkaraffe merged commit 620df75 into languagetool-org:master Jul 10, 2024
2 checks passed
@Luisa-LT
Copy link
Collaborator

🚀 🚀 🚀

@maphjo
Copy link
Collaborator

maphjo commented Jul 10, 2024

🎉 🚀 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luisa-LT Luisa-LT Luisa-LT requested changes

@danielnaber danielnaber danielnaber requested changes

@St-ac-y St-ac-y Awaiting requested review from St-ac-y

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@affemitkaraffe @Luisa-LT @maphjo @danielnaber @St-ac-y