Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fr] CONFUSION_E_ER-29-modified #10048

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Conversation

GillouLT
Copy link
Collaborator

@GillouLT GillouLT commented Jan 5, 2024

To address and close: https://github.com/languagetooler-gmbh/languagetool-premium/issues/6921

The scope of the rule has been narrowed down to a finite list of verbs, which will be much safer. On the other hand, we will have more FNs, those will most probably be detected by the model.

@@ -53665,7 +53664,6 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
<suggestion><match no="5" regexp_match="(?iu)er$" regexp_replace="é"/></suggestion>
<example correction="rassuré">Tu m'en vois <marker>rassurer</marker>.</example>
<example correction="proposé">Il se voit <marker>proposer</marker> d'épouser la fille de son bienfaiteur.</example>
<example correction="rassuré">Tu m'en vois <marker>rassurer</marker>.</example>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate

Copy link
Collaborator

@LucieSteib LucieSteib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
That's good!

@LucieSteib LucieSteib merged commit 19112a2 into master Jan 5, 2024
2 checks passed
@GillouLT GillouLT deleted the CONFUSION_E_ER-29-modified branch February 6, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants