Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[en] move dictionaries to a external dependency #10046

Merged
merged 6 commits into from
Jan 9, 2024
Merged

Conversation

jaumeortola
Copy link
Member

These are the current dictionaries, with no changes, moved to an external dependency.

@jaumeortola jaumeortola force-pushed the en-external-dict branch 2 times, most recently from 3816f81 to 84957f1 Compare January 6, 2024 13:53
@jaumeortola
Copy link
Member Author

This works now. There is only a minor issue with the tagging of good/well/best. @AzadehSafakish

I will create a diff with this branch. We cannot merge it without checking the diff.

@jaumeortola jaumeortola force-pushed the en-external-dict branch 2 times, most recently from 27e59e9 to dab5a39 Compare January 7, 2024 08:36
@AzadehSafakish
Copy link
Collaborator

AzadehSafakish commented Jan 8, 2024

@jaumeortola

I've looked over the diffs in this comment, and I don't see anything major.
I'm approving the PR.

However, to be safe, I'm not sure how I feel about merging this right before the Premium deployment.
Could it be merged after the greenlight for EN deployment tomorrow, so it doesn't go out to Premium users right away?

Also, I just added some words right before reviewing this; I resolved the conflict by adding the new words in added and spelling to the now empty files, but please let me know if I should revert the merge commit and move the new additions somewhere else.

@jaumeortola
Copy link
Member Author

However, to be safe, I'm not sure how I feel about merging this right before the Premium deployment.

I will merge the PR after the Premium sync.

@jaumeortola jaumeortola merged commit 2a5cf3c into master Jan 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants