Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[en] add words 1/03 #10044

Merged
merged 2 commits into from
Jan 4, 2024
Merged

[en] add words 1/03 #10044

merged 2 commits into from
Jan 4, 2024

Conversation

AzadehSafakish
Copy link
Collaborator

routine dictionary additions; PRing because I'm not sure why local mvn tests fail

@danielnaber
Copy link
Member

I'm not sure why local mvn tests fail

SpellingCheckRuleTest.testIgnoreSuggestionsWithMorfologik:57 » IndexOutOfBounds Index 0 out of bounds for length 0 -> you have added Michaelsand the test in line 57 fails now because that used to be a typo that had a suggestion, not it's not a typo and thus doesn't have a suggestion

@AzadehSafakish
Copy link
Collaborator Author

AzadehSafakish commented Jan 4, 2024 •
edited
Loading

you have added Michaels

I see, thank you.
It's the name of a large arts and crafts chain in the US, as well as a common surname.
Oddly enough, I just noticed that we already have a disambiguation rule to ignore the spelling...
I will remove change the test case.

@AzadehSafakish AzadehSafakish merged commit b73846d into languagetool-org:master Jan 4, 2024
2 checks passed
@AzadehSafakish AzadehSafakish deleted the add_words_jan3 branch January 4, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AzadehSafakish @danielnaber