Fix and test unsupported rule #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should never try to add real rules to a ruleset that wasn't really created (i.e. with a -1 file descriptor). Fix the From implementation for Compatibilty to always use CompatState::Init as an initial state. This is now possible because of the changes in create(), especially the new handling of no_new_privs. Simplify Ruleset:create() to only rely on compatibility state, which is now always correct. This is more future proof and this will help for upcoming restrictions. Extend the abi_v3_truncate() test to check with a new rule which may be incompatible. Fixes: ccb5a58 ("compat: Prioritize error over incompatibility") Signed-off-by: Mickaël Salaün <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should never try to add real rules to a ruleset that wasn't really created (i.e. with a -1 file descriptor).
Fix the From implementation for Compatibilty to always use CompatState::Init as an initial state. This is now possible because of the changes in create(), especially the new handling of no_new_privs.
Simplify Ruleset:create() to only rely on compatibility state, which is now always correct. This is more future proof and this will help for upcoming restrictions.
Extend the abi_v3_truncate() test to check with a new rule which may be incompatible.
Fixes #67