Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eigen-client-extra-features): blob size limit #325

Merged

Conversation

juan518munoz
Copy link

What ❔

Implement blob size limit for Eigen DA client

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

Copy link

@gianbelinche gianbelinche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add also a test for remote client for blob size limit

@juan518munoz
Copy link
Author

Maybe add also a test for remote client for blob size limit

The blob size check is done prior to either a memstore or remote dispersal, so a single test should cover both cases.

Copy link

@gianbelinche gianbelinche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from eigen-client-memstore to eigen-client-extra-features November 5, 2024 16:10
@juan518munoz juan518munoz merged commit b164870 into eigen-client-extra-features Nov 5, 2024
13 of 24 checks passed
@juan518munoz juan518munoz deleted the eigen-client-blob-size-limit branch November 5, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants