feat(eigen-client-extra-features): Add soft confirmations #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
juan518munoz
reviewed
Nov 1, 2024
juan518munoz
approved these changes
Nov 1, 2024
juanbono
reviewed
Nov 4, 2024
| let result = client.dispatch_blob(0, data.clone()).await.unwrap(); | ||
| let blob_info: BlobInfo = | ||
| rlp::decode(&hex::decode(result.blob_id.clone()).unwrap()).unwrap(); | ||
| // TODO: once get inclusion data is added, check it |
There was a problem hiding this comment.
I think inclusion was already added.
juanbono
reviewed
Nov 4, 2024
| eigenda_eth_rpc: String::default(), | ||
| eigenda_svc_manager_address: "0xD4A7E1Bd8015057293f0D0A557088c286942e84b".to_string(), | ||
| blob_size_limit: 2 * 1024 * 1024, // 2MB | ||
| status_query_timeout: 1800, // 30 minutes |
There was a problem hiding this comment.
is the configuration documented somewhere? I found confusing that the numbers in status_query_timeout and status_query_interval (both related to the status_query) have different units.
juanbono
approved these changes
Nov 4, 2024
samlaf
reviewed
Nov 4, 2024
| status_query_timeout: 1800000, // 30 minutes | ||
| status_query_interval: 5000, // 5000 ms | ||
| wait_for_finalization: true, | ||
| authenticaded: true, |
Base automatically changed from
eigen-client-memstore
to
eigen-client-extra-features
November 5, 2024 16:10
gianbelinche
merged commit f95bc1b
into
eigen-client-extra-features
7 of 9 checks passed
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR adds soft confirmations
Why ❔
Checklist
zkstack dev fmtandzkstack dev lint.